SkyMoney/docs/api-phase5-move-log.md

API Phase 5 Move Log

Date: 2026-03-17
Scope: Move fixed-plans endpoints out of api/src/server.ts into a dedicated route module.

Route Registration Changes

• Added fixed-plans route import in server.ts
• Registered fixed-plans routes in server.ts
• New canonical route module: fixed-plans.ts
• Removed inline fixed-plans route blocks from server.ts to avoid duplicate registration:
  • PATCH /fixed-plans/:id/early-funding
  • POST /fixed-plans/:id/attempt-final-funding
  • PATCH /fixed-plans/:id/mark-unpaid
  • POST /fixed-plans/:id/fund-from-available
  • POST /fixed-plans/:id/catch-up-funding
  • POST /fixed-plans
  • PATCH /fixed-plans/:id
  • DELETE /fixed-plans/:id
  • POST /fixed-plans/:id/true-up-actual
  • GET /fixed-plans/due
  • POST /fixed-plans/:id/pay-now

Endpoint Movements

1. PATCH /fixed-plans/:id/early-funding

• Original: server.ts line 1414
• Moved to fixed-plans.ts
• References:
  • EarlyPaymentPromptModal.tsx
  • EarlyFundingModal.tsx

2. POST /fixed-plans/:id/attempt-final-funding

• Original: server.ts line 1475
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • DashboardPage.tsx

3. PATCH /fixed-plans/:id/mark-unpaid

• Original: server.ts line 1635
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts

4. POST /fixed-plans/:id/fund-from-available

• Original: server.ts line 1674
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • PlansSettings.tsx

5. POST /fixed-plans/:id/catch-up-funding

• Original: server.ts line 1828
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • PlansSettings.tsx

6. POST /fixed-plans

• Original: server.ts line 2036
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • OnboardingPage.tsx
  • fixed-plans.estimated-true-up.test.ts

7. PATCH /fixed-plans/:id

• Original: server.ts line 2122
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • PlansSettings.tsx

8. DELETE /fixed-plans/:id

• Original: server.ts line 2239
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • PlansSettings.tsx

9. POST /fixed-plans/:id/true-up-actual

• Original: server.ts line 2285
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • PlansSettings.tsx
  • fixed-plans.estimated-true-up.test.ts

10. GET /fixed-plans/due

• Original: server.ts line 2429
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • DashboardPage.tsx

11. POST /fixed-plans/:id/pay-now

• Original: server.ts line 2495
• Moved to fixed-plans.ts
• References:
  • fixedPlans.ts
  • DashboardPage.tsx
  • fixed-plans.estimated-true-up.test.ts

Helper Ownership in Phase 5

• Shared helper injection from server.ts:
  • mutationRateLimit
  • computeDepositShares
  • computeWithdrawShares
  • calculateNextDueDate
  • toBig
• Route-local helper:
  • DAY_MS constant for date-window computations
  • PlanBody / PlanAmountMode zod schemas

Verification

1. Build

• cd api && npm run build ✅

2. Focused tests

• cd api && npm run test -- tests/fixed-plans.estimated-true-up.test.ts tests/payment-rollover.test.ts tests/transactions.test.ts
• Result: blocked by local DB connectivity (127.0.0.1:5432 unavailable), suites skipped/failed before endpoint assertions.