SkyMoney/docs/api-phase3-move-log.md

API Phase 3 Move Log

Date: 2026-03-16
Scope: Move variable-categories endpoints out of api/src/server.ts into a dedicated route module.

Route Registration Changes

• Added variable-categories route import in server.ts
• Registered variable-categories routes in server.ts
• New canonical route module: variable-categories.ts
• Removed inline variable-categories route block from server.ts to avoid duplicate endpoint registration.

Endpoint Movements

1. POST /variable-categories

• Moved to variable-categories.ts
• References:
  • categories.ts
  • variable-categories.guard.test.ts

2. PATCH /variable-categories/:id

• Moved to variable-categories.ts
• References:
  • categories.ts
  • variable-categories.guard.test.ts

3. DELETE /variable-categories/:id

• Moved to variable-categories.ts
• References:
  • categories.ts
  • CategoriesSettings.tsx

4. POST /variable-categories/rebalance

• Moved to variable-categories.ts
• References:
  • categories.ts
  • CategoriesSettings.tsx

5. GET /variable-categories/manual-rebalance

• Moved to variable-categories.ts
• References:
  • rebalance.ts
  • variable-categories.manual-rebalance.test.ts

6. POST /variable-categories/manual-rebalance

• Moved to variable-categories.ts
• References:
  • rebalance.ts
  • RebalancePage.tsx
  • variable-categories.manual-rebalance.test.ts

Helper Ownership in Phase 3

• Kept variable-category-specific helpers local to the route module:
  • assertPercentTotal
  • getLatestBudgetSession
  • ensureBudgetSession
  • ensureBudgetSessionAvailableSynced
• Reused shared server helper by injection:
  • computeDepositShares injected from server.ts registration.
• Reused shared mutation throttling by injection:
  • mutationRateLimit injected from server.ts registration.

Follow-ups To Revisit

1. Consolidate budget-session sync helpers into a shared service (api/src/services/budget-session.ts) once Phase 4 starts.
2. Standardize response error envelopes for variable-category routes (message vs ok/code/message) to reduce client branching.
3. Recheck variable-categories.manual-rebalance.test.ts over-80 error-code expectation versus current confirm-style behavior to keep tests aligned with product policy.